make pointer types in ctypes.wintypes subclasses instead of aliases#11126
Merged
JelleZijlstra merged 1 commit intopython:mainfrom Dec 10, 2023
Merged
make pointer types in ctypes.wintypes subclasses instead of aliases#11126JelleZijlstra merged 1 commit intopython:mainfrom
JelleZijlstra merged 1 commit intopython:mainfrom
Conversation
tungol
commented
Dec 9, 2023
Comment on lines
-189
to
-190
| # These pointer type definitions use _Pointer[...] instead of POINTER(...), to allow them | ||
| # to be used in type annotations. |
Contributor
Author
There was a problem hiding this comment.
I removed the comment because it seemed redundant: POINTER() is used to define these at runtime, but it's a runtime function. That's not appropriate for use in typeshed by definition.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Avasam
approved these changes
Dec 9, 2023
Collaborator
There was a problem hiding this comment.
Thanks! Your changes do look more correct than before:
>>> ctypes.wintypes.PBOOL
<class 'ctypes.wintypes.LP_c_long'>
>>> type(ctypes.wintypes.PBOOL)
<class '_ctypes.PyCPointerType'>
>>> ctypes.wintypes.PBOOL.__bases__
(<class '_ctypes._Pointer'>,)
>>> type(ctypes.wintypes.PBOOL.__bases__[0])
<class '_ctypes.PyCPointerType'>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #3968