gevent: Use TypeVarTuple instead of old ParamSpec workaround.#11129
Merged
JelleZijlstra merged 3 commits intopython:mainfrom Dec 10, 2023
Merged
gevent: Use TypeVarTuple instead of old ParamSpec workaround.#11129JelleZijlstra merged 3 commits intopython:mainfrom
TypeVarTuple instead of old ParamSpec workaround.#11129JelleZijlstra merged 3 commits intopython:mainfrom
Conversation
Member
Eh, I disagree. Let's make the changes that are possible now, and defer the changes that aren't possible just yet. Incremental improvements will benefit the users of these stubs more than waiting until we can do everything all at once :) |
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going to have the same pytype issue as #11128 for
BaseServer, but it's probably still not worth splitting theBaseServerchange into its own PR.