tensorflow: Add members from tensorflow.keras.metrics

[hoel-bagard]

These subs are taken from: https://github.com/hmc-cs-mdrissi/tensorflow_stubs/blob/main/stubs/tensorflow/keras/metrics.pyi

[hoel-bagard]

@hmc-cs-mdrissi If you have time to review it.

[JelleZijlstra]

FYI this has a merge conflict now.

[hoel-bagard]

@JelleZijlstra The CI was passing before merging with main, but now there is an error with the imports that I do not understand. Would you have an idea of what is causing it ?

[JelleZijlstra]

There was a failing stubtest job with no output; I reran it.

There is also a pytype crash:

  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pytype/pytd/visitors.py", line 512, in VisitNamedType
    raise KeyError(f"No {name} in module {module_name}") from e
KeyError: 'No ABCMeta in module importlib.resources.abc'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/runner/work/typeshed/typeshed/./tests/pytype_test.py", line 88, in run_pytype
    loader.finish_and_verify_ast(ast)
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pytype/load_pytd.py", line 632, in finish_and_verify_ast
    self._modules[k].ast = self._resolve_external_types(
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pytype/load_pytd.py", line 526, in _resolve_external_types
    mod_ast = self._resolver.resolve_external_types(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pytype/load_pytd.py", line 283, in resolve_external_types
    raise BadDependencyError(key, name) from e
pytype.load_pytd.BadDependencyError: No ABCMeta in module importlib.resources.abc, referenced from 'tensorflow.keras.metrics'

Which looks more mysterious, since I don't see how this PR relates to importlib.resources. cc @rchen152

[hmc-cs-mdrissi]

This also looks like an inherited method so metrics class shouldn't have it defined. Add it to Layer class if it's not already there.

[hoel-bagard]

Done in e9246aa. It was already inherited from Layer indeed.

[hoel-bagard]

@hmc-cs-mdrissi The add_weight from keras.metrics.Metric is different from the one from keras.layers.Layer, so I need to redefine it. However I'm facing the same error I had in another PR with MultiHeadAttention. Even if I add the method to the stubtest_allowlist, mypy still reports an error.

[hmc-cs-mdrissi]

# type: ignore works for that. stubtest allowlist is for runtime vs stub checks. Before that happens there's also a mypy pass. And you can use normal # type: ignore to handle that.

[hmc-cs-mdrissi]

Generally get mypy passing first. No need to consider allowlist and then after mypy is green work on stubtest errors, and use allowlist when appropriate.

[hoel-bagard]

Ok, thanks.

[rchen152]

There was a failing stubtest job with no output; I reran it.

There is also a pytype crash:

  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pytype/pytd/visitors.py", line 512, in VisitNamedType
    raise KeyError(f"No {name} in module {module_name}") from e
KeyError: 'No ABCMeta in module importlib.resources.abc'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/runner/work/typeshed/typeshed/./tests/pytype_test.py", line 88, in run_pytype
    loader.finish_and_verify_ast(ast)
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pytype/load_pytd.py", line 632, in finish_and_verify_ast
    self._modules[k].ast = self._resolve_external_types(
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pytype/load_pytd.py", line 526, in _resolve_external_types
    mod_ast = self._resolver.resolve_external_types(
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/pytype/load_pytd.py", line 283, in resolve_external_types
    raise BadDependencyError(key, name) from e
pytype.load_pytd.BadDependencyError: No ABCMeta in module importlib.resources.abc, referenced from 'tensorflow.keras.metrics'

Which looks more mysterious, since I don't see how this PR relates to importlib.resources. cc @rchen152

Yeah, this was a weird one! Turns out it was an issue with how pytype resolves module aliases. I have a fix out for review, but I might not be able to release a new version of pytype until sometime next week, as we have a few big changes in the pipeline.

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

[rchen152]

Yeah, this was a weird one! Turns out it was an issue with how pytype resolves module aliases. I have a fix out for review, but I might not be able to release a new version of pytype until sometime next week, as we have a few big changes in the pipeline.

Sorry, this took longer than expected, but pytype-2024.02.09 is out with this fix.

[hoel-bagard]

Thank you!