Bump braintree to 4.33.*#13511
Merged
srittau merged 2 commits intopython:mainfrom Feb 18, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Feb 18, 2025
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thanks, one note about stubgen-generated re-exports below.
Comment on lines
+3
to
+14
| from braintree.error_result import ErrorResult as ErrorResult | ||
| from braintree.exceptions.unexpected_error import UnexpectedError as UnexpectedError | ||
| from braintree.graphql import ( | ||
| CreateCustomerSessionInput as CreateCustomerSessionInput, | ||
| CustomerRecommendations as CustomerRecommendations, | ||
| CustomerRecommendationsInput as CustomerRecommendationsInput, | ||
| CustomerRecommendationsPayload as CustomerRecommendationsPayload, | ||
| PaymentOptions as PaymentOptions, | ||
| UpdateCustomerSessionInput as UpdateCustomerSessionInput, | ||
| ) | ||
| from braintree.successful_result import SuccessfulResult as SuccessfulResult | ||
| from braintree.util.graphql_client import GraphQLClient as GraphQLClient |
Collaborator
There was a problem hiding this comment.
I don't think we should re-export those imports. Same for the other non-__init__ files below.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated stubs for the new
graphqldirectory & added the other new APIs.closes #13445