Return BufferedIncrementalReader for some encodings#13523
Merged
srittau merged 5 commits intopython:mainfrom Feb 22, 2025
Merged
Return BufferedIncrementalReader for some encodings#13523srittau merged 5 commits intopython:mainfrom
srittau merged 5 commits intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: yarl (https://github.com/aio-libs/yarl)
+ yarl/_quoting_py.py:132:19: error: Redundant cast to "BufferedIncrementalDecoder" [redundant-cast]
|
srittau
approved these changes
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to get the more specific Buffered class for the correct encodings (especially utf-8, which is the most common case). We currently cast() this in yarl.
Note that I've not included the aliases here (https://github.com/python/cpython/blob/38642bff139bde5c0118bc75fda25badc76b85fc/Lib/encodings/aliases.py#L505-L538), so it will only work when using the canonical name. This could be expanded to include aliases if that's desired, or reduced to only utf-8 to handle the most common case. Let me know what seems preferable.