Skip to content

Fix: OAuth1 type hints to include realm parameter#13579

Merged
srittau merged 4 commits intopython:mainfrom
Mr-Sunglasses:fix/13463
Mar 5, 2025
Merged

Fix: OAuth1 type hints to include realm parameter#13579
srittau merged 4 commits intopython:mainfrom
Mr-Sunglasses:fix/13463

Conversation

@Mr-Sunglasses
Copy link
Copy Markdown
Contributor

fix: #13463

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One nit below.

Comment thread stubs/requests-oauthlib/requests_oauthlib/oauth1_auth.pyi Outdated
Copy link
Copy Markdown
Contributor Author

@Mr-Sunglasses Mr-Sunglasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srittau , I've made the changes.

@Mr-Sunglasses Mr-Sunglasses requested a review from srittau March 5, 2025 17:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 5, 2025

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 91a90ed into python:main Mar 5, 2025
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requests_oauthlib OAuth1 is incorrectly typed

2 participants