Some minor statistics.NormalDist adjustments#13626
Merged
AlexWaygood merged 8 commits intopython:mainfrom Mar 15, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Mar 15, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Mostly looks good! A few comments
Member
I'm fine with this change. I wouldn't necessarily prioritising fixing lots of dunder parameter names all over the stdlib with similar changes (it's not that important). But it's strictly more accurate to the runtime implementation, so I won't say "no" now that you've made the change :-) |
This reverts commit 0465c2b.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This comment has been minimized.
This comment has been minimized.
This reverts commit 2696323.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some opportunities for improvement when I compared the stub with the cpython implementation.
I'm not really sure about the last commit (the
self->x1renames), so I'm curious to see what others think about it, and wouldn't mind reverting.