add __init__ to Logger#1415
Merged
gvanrossum merged 2 commits intopython:masterfrom Jun 20, 2017
amstree:logger-init
Merged
Conversation
matthiaskramm
suggested changes
Jun 19, 2017
|
|
||
| class Logger: | ||
| name = ... # type: str | ||
| name = ... # type: Text |
Contributor
There was a problem hiding this comment.
Text maps to unicode, on Python 2, but name can be a (byte)string, as well. I think str was a better annotation here, unless you actually want to create Loggers with a unicode name on Python 2.
added 2 commits
June 19, 2017 20:29
Member
|
I assume @matthias would be satisfied with the latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__init__to Logger