Improve csv module and float() signature#1418
Merged
matthiaskramm merged 4 commits intomasterfrom Jun 20, 2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent changes to the csv stubs (#1398) introduced more precise types but also some problems. I am fixing those problems here:
DictReaderaccidentally became an abstract class. I made it concrete again by adding definitions for__iter__()andnext().restvalargument toDictWriter.__init__()accidentally became mandatory. I made itOptionalagain.reader()should beIterable, notIterator.Running with these improvements against our internal codebase also revealed a problem when
float()is called with an argument of typeUnion[str, int]. I fixed this by switching the signature offloat.__init__()from using@overloadto usingUnion.