[geopandas] Some @final methods are overridden

[srittau]

Closes: #14655

[AlexWaygood]

I wonder if it might be worth putting a lower bound on our pandas-stubs dependency here?

typeshed/stubs/geopandas/METADATA.toml

Line 3 in ff32af2

requires = ["numpy>=1.20", "pandas-stubs", "types-shapely", "pyproj"]

The breakage was caused by a new pandas-stubs release. But putting a lower bound wouldn't stop us being broken by the next pandas-stubs release, and if you have an older version of pandas-stubs installed then type checkers will just find some of the new type: ignores here unnecessary -- that shouldn't cause them to emit diagnostics when analysing user code. So there would probably be marginal benefit in adding a lower bound, and some cost as well.

[srittau]

The breakage was caused by a new pandas-stubs release. But putting a lower bound wouldn't stop us being broken by the next pandas-stubs release, and if you have an older version of pandas-stubs installed then type checkers will just find some of the new type: ignores here unnecessary -- that shouldn't cause them to emit diagnostics when analysing user code. So there would probably be marginal benefit in adding a lower bound, and some cost as well.

So am I right in reading your conclusion as: "No, let's not do that, because there's no benefit, but rather a slight regression for users"? 😀 In that case I would agree, although I'm a bit indifferent overall.

[AlexWaygood]

So am I right in reading your conclusion as: "No, let's not do that, because there's no benefit, but rather a slight regression for users"? 😀 In that case I would agree, although I'm a bit indifferent overall.

Yes! But I decided to show my working in how I reached that conclusion ;)

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

discord.py (https://github.com/Rapptz/discord.py)
- discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "description", "name"  [misc]
+ discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "name", "description"  [misc]
- discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "description", "name"  [misc]
+ discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "name", "description"  [misc]
- discord/ext/commands/hybrid.py:834: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
+ discord/ext/commands/hybrid.py:834: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
- discord/ext/commands/hybrid.py:858: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
+ discord/ext/commands/hybrid.py:858: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
- discord/ext/commands/hybrid.py:883: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
+ discord/ext/commands/hybrid.py:883: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
- discord/ext/commands/hybrid.py:935: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
+ discord/ext/commands/hybrid.py:935: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
- discord/ext/commands/bot.py:290: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
+ discord/ext/commands/bot.py:290: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
- discord/ext/commands/bot.py:314: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
+ discord/ext/commands/bot.py:314: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]