-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Tiny grammar corrections #14910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Tiny grammar corrections #14910
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,10 +7,10 @@ | |
| ## About | ||
|
|
||
| Typeshed contains external type annotations for the Python standard library | ||
| and Python builtins, as well as third party packages as contributed by | ||
| and Python builtins, as well as third-party packages that are contributed by | ||
| people external to those projects. | ||
|
|
||
| This data can e.g. be used for static analysis, type checking, type inference, | ||
| This data can, e.g., be used for static analysis, type checking, type inference, | ||
| and autocompletion. | ||
|
|
||
| For information on how to use typeshed, read below. Information for | ||
|
|
@@ -29,8 +29,8 @@ If you're just using a type checker (e.g. [mypy](https://github.com/python/mypy/ | |
| [pyright](https://github.com/microsoft/pyright), or PyCharm's built-in type | ||
| checker), as opposed to | ||
| developing it, you don't need to interact with the typeshed repo at | ||
| all: a copy of standard library part of typeshed is bundled with type checkers. | ||
| And type stubs for third party packages and modules you are using can | ||
| all: a copy of the standard library part of typeshed is bundled with type checkers. | ||
| And type stubs for third-party packages and modules you are using can | ||
| be installed from PyPI. For example, if you are using `html5lib` and `requests`, | ||
| you can install the type stubs using | ||
|
|
||
|
|
@@ -70,7 +70,7 @@ package you're using, each with its own tradeoffs: | |
| type checking due to changes in the stubs. | ||
|
|
||
| Another risk of this strategy is that stubs often lag behind | ||
| the package being stubbed. You might want to force the package being stubbed | ||
| the package that is being stubbed. You might want to force the package being stubbed | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This reads better without "that is". |
||
| to a certain minimum version because it fixes a critical bug, but if | ||
| correspondingly updated stubs have not been released, your type | ||
| checking results may not be fully accurate. | ||
|
|
@@ -119,6 +119,6 @@ a review of your type annotations or stubs outside of typeshed, head over to | |
| [our discussion forum](https://github.com/python/typing/discussions). | ||
| For less formal discussion, try the typing chat room on | ||
| [gitter.im](https://gitter.im/python/typing). Some typeshed maintainers | ||
| are almost always present; feel free to find us there and we're happy | ||
| are almost always present; feel free to find us there, and we're happy | ||
| to chat. Substantive technical discussion will be directed to the | ||
| issue tracker. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds ungrammatical to me, should be "that have been", or just omit the "that are" part.