Skip to content

Conversation

@StanFromIreland
Copy link
Member

$ python3.14
Python 3.14.0 (main, Oct  7 2025, 00:00:00) [GCC 15.2.1 20250808 (Red Hat 15.2.1-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import zlib; zlib.ZLIBNG_VERSION
'2.2.5'

Update condition for ZLIBNG_VERSION availability.
@StanFromIreland
Copy link
Member Author

cc @emmatyping

@github-actions

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented Oct 30, 2025

This seems not to be always true:

>>> import zlib; zlib.ZLIBNG_VERSION
Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    import zlib; zlib.ZLIBNG_VERSION
                 ^^^^^^^^^^^^^^^^^^^
AttributeError: module 'zlib' has no attribute 'ZLIBNG_VERSION'. Did you mean: 'ZLIB_VERSION'?

(Ubuntu 24.04.3 LTS, Python installed via pyenv.) That said, even if it's only sometimes available, we should add it with an appropriate comment.

@StanFromIreland
Copy link
Member Author

This seems not to be always true:

It varies on how it was built, in the Fedora releases it is present.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 947ec49 into python:main Oct 30, 2025
63 checks passed
@StanFromIreland StanFromIreland deleted the patch-1 branch October 30, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants