[python-dateutil] add some missing parameter types #14992
Merged
+58
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Nov 7, 2025
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thanks, just a few notes.
Comment on lines
66
to
67
| # args and kwargs are passed to list.__init__ | ||
| def __init__(self, *args: Any, **kwargs: Any) -> None: ... |
Collaborator
There was a problem hiding this comment.
In that case we should either copy the list constructor or probably just remove it from _ymt and let it inherit the signature from list.
| def could_be_day(self, value): ... | ||
| def append(self, val, label=None): ... | ||
| def _resolve_from_stridxs(self, strids): ... | ||
| def could_be_day(self, value: int): ... |
Collaborator
There was a problem hiding this comment.
Suggested change
| def could_be_day(self, value: int): ... | |
| def could_be_day(self, value: int) -> bool: ... |
| def append(self, val, label=None): ... | ||
| def _resolve_from_stridxs(self, strids): ... | ||
| def could_be_day(self, value: int): ... | ||
| def append(self, val: str | int, label: str | None = None): ... |
Collaborator
There was a problem hiding this comment.
Suggested change
| def append(self, val: str | int, label: str | None = None): ... | |
| def append(self, val: str | int, label: str | None = None) -> None: ... |
Contributor
Author
|
thank you for the suggestions! |
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: core (https://github.com/home-assistant/core)
+ homeassistant/components/habitica/calendar.py:101: error: Redundant cast to "list[datetime]" [redundant-cast]
|
srittau
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.