[pycountry] Add stubs for pycountry 24.6.1 (closes #15001) #15002
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
donbarbos
left a comment
donbarbos
left a comment
There was a problem hiding this comment.
Thanks! I’m not sure how relevant adding these stubs to typeshed would be, but I just wanted to point out a few small nits.
stubs/pycountry/METADATA.toml
Outdated
| version = "24.6.*" | ||
| upstream_repository = "https://github.com/pycountry/pycountry" | ||
|
|
||
| [tool.stubtest] | ||
| skip = false |
There was a problem hiding this comment.
We don't use alignment in METADATA.toml, so let's keep the consistent style, and defaults value of skip is false
| version = "24.6.*" | |
| upstream_repository = "https://github.com/pycountry/pycountry" | |
| [tool.stubtest] | |
| skip = false | |
| version = "24.6.*" | |
| upstream_repository = "https://github.com/pycountry/pycountry" |
There was a problem hiding this comment.
Thank you!
stubs/pycountry/pycountry/db.pyi
Outdated
| class Country(Data): ... | ||
| class Subdivision(Data): ... | ||
|
|
||
| def lazy_load(f: _F) -> _F: ... |
There was a problem hiding this comment.
A more suitable way here is to use Callable with ParamSpec and TypeVar inside:
| def lazy_load(f: _F) -> _F: ... | |
| def lazy_load(f: Callable[_P, _R]) -> Callable[_P, _R]: ... |
There was a problem hiding this comment.
Thank you!
stubs/pycountry/pycountry/db.pyi
Outdated
| @lazy_load | ||
| def __len__(self) -> int: ... | ||
| @lazy_load | ||
| def get(self, *, default: Data | None = ..., **kw: Any) -> Data | None: ... |
There was a problem hiding this comment.
There is a check inside that kw should be str, so I don't see any reason to set it to Any.
| def get(self, *, default: Data | None = ..., **kw: Any) -> Data | None: ... | |
| def get(self, *, default: Data | None = ..., **kw: str) -> Data | None: ... |
There was a problem hiding this comment.
Thank you!
stubs/pycountry/pycountry/db.pyi
Outdated
| @lazy_load | ||
| def add_entry(self, **kw: str) -> None: ... | ||
| @lazy_load | ||
| def remove_entry(self, **kw: Any) -> None: ... |
There was a problem hiding this comment.
this kw are passed on to self.get, so the situation here is similar, see below
| def remove_entry(self, **kw: Any) -> None: ... | |
| def remove_entry(self, **kw: str) -> None: ... |
There was a problem hiding this comment.
Thank you!
stubs/pycountry/pycountry/db.pyi
Outdated
|
|
||
| logger: logging.Logger | ||
|
|
||
| _F = TypeVar("_F", bound=Callable[..., Any]) |
There was a problem hiding this comment.
see below
| _F = TypeVar("_F", bound=Callable[..., Any]) | |
| _P = ParamSpec("_P") | |
| _R = TypeVar("_R") |
There was a problem hiding this comment.
Thank you! I imported ParamSpec from typing_extensions for Python 3.9 - is that correct?
Add type stubs for pycountry 24.6.*, providing type annotations for: - Database classes (ExistingCountries, HistoricCountries, Currencies, Languages, Scripts, etc.) - SubdivisionHierarchy and Subdivisions classes - Core data classes (Country, Subdivision, Data) - Module-level functions and constants
jochemvangrondelle
force-pushed
the
pycountry/24.6.1
branch
from
2e5f9f8 to
ada29a1
Compare
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
3 participants
Add type stubs for pycountry 24.6.*, providing type annotations for:
The pycountry upstream is marked with py.typed but code base not yet fully typed. Already have related MR for upstream pycountry to complete type hints; but due to slower pycountry release; added the type hints here for completeness.