Add TypeVars for the Iterators in select.select #15022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in 2017, #1080 added in
TypeVarto handle correctly indicating how the arguments forselect.selectwere passed through to the return values. But unfortunately it caused issues for when an empty Iterator was provided for an argument, asmypycould not resolve the type, so it was reverted in #1097But now,
TypeVarhas an optionaldefaultargument that is used to set a default when the type is not provided, and we have theNevertype to indicate a case where there is an empty list. By combining the two , it is now possible to support more descriptive types.