Align type of aws_xra_sdk.core.xray_recorder stub with lib #15107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The two failing checks seem to be caused by problems while cloning repos from GitLab, so unrelated to my change? |
`aws_xra_sdk.core.xray_recorder` has unconditionally been an instance of `AsyncAWSXRayRecorder`, not `AWSXRayRecorder`, since `aws-xray-sdk==2.12.1`, see: aws/aws-xray-sdk-python@150f0ea
dlukes
force-pushed
the
dalukes/aws-xray-sdk-async-recorder
branch
from
79a69aa to
27e024c
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Contributor
Author
|
OK, amended the commit and force-pushed and now CI is passing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws_xra_sdk.core.xray_recorderhas unconditionally been an instance ofAsyncAWSXRayRecorder, notAWSXRayRecorder, sinceaws-xray-sdk==2.12.1, see:aws/aws-xray-sdk-python@150f0ea