Merged
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Mar 15, 2026
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thanks, comments below.
| hash_id: str | bytes | None = None, | ||
| implement_cron_bug: bool = False, | ||
| second_at_beginning: bool | None = None, | ||
| second_at_beginning: bool = False, |
Collaborator
There was a problem hiding this comment.
In theory, supplying None would still work, but considering there's no primer output and using bool is what is intended, I think not allowing it here is okay.
Contributor
Author
There was a problem hiding this comment.
I decided to leave only bool, so it would be like in other methods/params. I think if we allow None, then we should do the same for many other parameters
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #15510