Fix Final literal values in various third-party stubs#15521
Merged
JelleZijlstra merged 1 commit intopython:mainfrom Mar 16, 2026
Merged
Fix Final literal values in various third-party stubs#15521JelleZijlstra merged 1 commit intopython:mainfrom
Final literal values in various third-party stubs#15521JelleZijlstra merged 1 commit intopython:mainfrom
Conversation
brianschubert
commented
Mar 16, 2026
| _Observer: TypeAlias = Callable[[StateMachine[_Context]], None] | ||
|
|
||
| __docformat__: Final = "reStructuredText" | ||
| __docformat__: Final = "restructuredtext" |
Collaborator
Author
There was a problem hiding this comment.
| BLACK: Final = "00000000" | ||
| WHITE: Final = "00FFFFFF" | ||
| BLUE: Final = "00FFFFFF" | ||
| BLUE: Final = "000000FF" |
Collaborator
Author
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
The runtime values have an actual embedded tab character, not \ t
https://github.com/Pylons/waitress/blob/main/src/waitress/rfc7230.py
Comment on lines
+88
to
+90
| COMPILE_LIBCURL_VERSION_NUM: Final[int] | ||
| COMPILE_PY_VERSION_HEX: Final[int] | ||
| COMPILE_SSL_LIB: Final[str] |
Collaborator
Author
There was a problem hiding this comment.
Unstable, depend on the versions the module was compiled with
| HTTPAUTH_NTLM: Final = 8 | ||
| HTTPAUTH_NTLM_WB: Final = 32 | ||
| HTTPAUTH_ONLY: Final = -2147483648 | ||
| HTTPAUTH_ONLY: Final[int] |
Collaborator
Author
There was a problem hiding this comment.
Value differs between platforms: -2147483648 on the Windows runners, +2147483648 on the MacOS and Linux runners
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by running stubtest with python/mypy#20858