Add @type_check_only for ignored third-party stubs#15535
Merged
brianschubert merged 2 commits intopython:mainfrom Mar 21, 2026
Merged
Add @type_check_only for ignored third-party stubs#15535brianschubert merged 2 commits intopython:mainfrom
@type_check_only for ignored third-party stubs#15535brianschubert merged 2 commits intopython:mainfrom
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
brianschubert
approved these changes
Mar 21, 2026
Collaborator
brianschubert
left a comment
brianschubert
left a comment
There was a problem hiding this comment.
Nice, thank you!
A few of these are actually from non-ignored stubs but which I hadn't got around to fixing:
error: docker.types.services._ResourceDict is not present at runtime. Maybe mark it as "@type_check_only"?
error: docutils._VersionInfo is not present at runtime. Maybe mark it as "@type_check_only"?
error: fpdf.drawing._DeviceCMYKBase is not present at runtime. Maybe mark it as "@type_check_only"?
error: fpdf.drawing._DeviceGrayBase is not present at runtime. Maybe mark it as "@type_check_only"?
error: fpdf.drawing._DeviceRGBBase is not present at runtime. Maybe mark it as "@type_check_only"?
The rest I verified are in stub-only or otherwise stubtest-ignored modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.