Fix accepted types in select.select#15757
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: spark (https://github.com/apache/spark)
+ python/pyspark/daemon.py:193: error: Value of type variable "_R" of "select" cannot be "object" [type-var]
operator (https://github.com/canonical/operator)
+ ops/pebble.py:1902: error: Value of type variable "_R" of "select" cannot be "object" [type-var]
|
srittau
approved these changes
May 11, 2026
tkem
pushed a commit
to tkem/typeshed
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No errors happen in type checking time for
select(['a'], ['b'], ['c']). See https://mypy-play.net/?gist=2a5c9fcecebd7dbfd6f9823f605da0e5Not any values are allowed in
select.select. It only allowsint | HasFilenoitems. See:Why is that?
seq2set: https://github.com/python/cpython/blob/53c3dd9a8d79a331764147b7b7b01f9d0a8bce71/Modules/selectmodule.c#L344-L349seq2setcallsPyObject_AsFileDescriptoron list items https://github.com/python/cpython/blob/53c3dd9a8d79a331764147b7b7b01f9d0a8bce71/Modules/selectmodule.c#L168intorHasFilenotype: https://github.com/python/cpython/blob/53c3dd9a8d79a331764147b7b7b01f9d0a8bce71/Objects/fileobject.c#L172-L182