itertools.pyi: Add overload to Python 3#2659
Merged
JelleZijlstra merged 2 commits intopython:masterfrom Nov 30, 2018
Merged
Conversation
| @@ -97,6 +97,8 @@ def product(iter1: Iterable[Any], | |||
| *iterables: Iterable[Any]) -> Iterator[Tuple[Any, ...]]: ... | |||
| @overload | |||
| def product(*iterables: Iterable[Any], repeat: int) -> Iterator[Tuple[Any, ...]]: ... | |||
Member
There was a problem hiding this comment.
Does just adding = ... to repeat here work? I feel like this and the next overload would be overlapping.
Contributor
Author
There was a problem hiding this comment.
So should I add the repeat: int = ... and remove the next overload, @JelleZijlstra?
Yeah, seems fine. Gonna give it a try,
Collaborator
|
Unfortunately we lose the information that an empty tuple is returned when no iterables are passed in, but this is probably the best we can do. |
JelleZijlstra
approved these changes
Nov 30, 2018
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an overload to Python 3 version which was missing.
Fixes #2561