Skip to content

Drop support for Python 3.5#4675

Merged
srittau merged 4 commits into
python:masterfrom
srittau:drop-py35
Nov 2, 2020
Merged

Drop support for Python 3.5#4675
srittau merged 4 commits into
python:masterfrom
srittau:drop-py35

Conversation

@srittau
Copy link
Copy Markdown
Collaborator

@srittau srittau commented Oct 15, 2020

Python 3.5 EOL was on 2020-09-30.

Comment thread scripts/migrate_script.py
Copy link
Copy Markdown
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Looks good as far as I can tell.

I don't have a good sense of when the right time to start burying 3.5's corpse is, so trusting you on that. It looks like we waited four months past EOL for 3.4.
Note @JukkaL expressed some reluctance recently: python/mypy#9536 (comment) For mypy, 3.5 seems to account for only a small share of downloads (although we don't know what version of Python people are targetting).
In terms of precedent setting, time will tell, but I think we might want to be a little slower when 3.6's time comes.

@JukkaL
Copy link
Copy Markdown
Contributor

JukkaL commented Oct 16, 2020

The decision to drop 3.5 support in typeshed can be orthogonal to the decision to drop 3.5 support in mypy, I think. Type checking Python 3.5 code will be possible (though somewhat limited) even without explicit support in typeshed. Mypy just won't be able to flag uses of Python 3.6 library features when targeting 3.5. Almost all changes in 3.6 seem to add new functionality instead of removing existing functionality or modifying things in incompatible ways.

Starting from the next mypy release, I'm fine with 3.5 support being incomplete. The main thing is being able to run mypy using Python 3.5 when that's what ships with the operating system.

@JelleZijlstra
Copy link
Copy Markdown
Member

I'm OK with doing this, but there's a ton of merge conflicts.

@github-actions

This comment has been minimized.

@srittau
Copy link
Copy Markdown
Collaborator Author

srittau commented Nov 2, 2020

@JelleZijlstra I rebased the PR on current master.

Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but do you know what's going on with mypy-primer here?

@JelleZijlstra
Copy link
Copy Markdown
Member

Oh, I guess that might just have been because of a bad merge that produced syntax errors in a few files.

@srittau srittau merged commit d2a7889 into python:master Nov 2, 2020
@srittau srittau deleted the drop-py35 branch November 2, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants