future first: switch the order of some if statements #5206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're adding this to our contribution guidelines in python#5205
Member
|
Thanks for putting in all the work here! Clearly the convention isn't as universal as I thought; maybe it's not worth standardizing? |
Collaborator
Author
|
I'd say it's pretty predominant, I reckon this is a fraction of sys.version checks (maybe 10%). "worth it" is really subjective for this kind of thing, but I do prefer it / consciously phrase if-statements this way in my PRs (many of which introduce sys.version checks) |
SergeyZh
pushed a commit
to JetBrains/intellij-community
that referenced
this pull request
Apr 28, 2021
Temporarily exclude python/typeshed#4987 Temporarily exclude python/typeshed#5206 from `collections/__init__.pyi` GitOrigin-RevId: 78775cc6c09fd8d867d8f46bf9908bd5cdbb05f6
SergeyZh
pushed a commit
to JetBrains/intellij-community
that referenced
this pull request
May 27, 2021
…10, PY-44548, PY-46355, PY-48948, PY-48958) Temporarily exclude python/typeshed#4987 Temporarily exclude python/typeshed#5206 from `collections/__init__.pyi` GitOrigin-RevId: 1bf4e6120ecd5927a113716878e503239ba33873
SergeyZh
pushed a commit
to JetBrains/intellij-community
that referenced
this pull request
Aug 18, 2021
Temporarily exclude python/typeshed#4987 Temporarily exclude python/typeshed#5206 from `collections/__init__.pyi` GitOrigin-RevId: 6146af923d749b0cff56e823101b8f2b8525383d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're adding this to our contribution guidelines in
#5205