Skip to content

correct asyncio.locks._ContextManagerMixin and _ContextManager types #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akuli merged 6 commits into from
Feb 4, 2022
Merged

correct asyncio.locks._ContextManagerMixin and _ContextManager types #7124

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7e2174e
correct asyncio.locks._ContextManagerMixin and _ContextManager types
graingert Feb 3, 2022
0409eb5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 3, 2022
24e57c0
Merge branch 'master' into patch-6
graingert Feb 4, 2022
5b0d390
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 4, 2022
9017e6b
Update stdlib/asyncio/locks.pyi
Akuli Feb 4, 2022
4b1d6a3
Update stdlib/asyncio/locks.pyi
Akuli Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions stdlib/asyncio/locks.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ _T = TypeVar("_T")

if sys.version_info >= (3, 9):
class _ContextManagerMixin:
def __init__(self, lock: Lock | Semaphore) -> None: ...
async def __aenter__(self) -> None: ...
async def __aexit__(
self, exc_type: type[BaseException] | None, exc: BaseException | None, tb: TracebackType | None
Expand All @@ -20,14 +19,13 @@ if sys.version_info >= (3, 9):
else:
class _ContextManager:
def __init__(self, lock: Lock | Semaphore) -> None: ...
def __enter__(self) -> object: ...
def __enter__(self) -> None: ...
def __exit__(self, *args: Any) -> None: ...

class _ContextManagerMixin:
def __init__(self, lock: Lock | Semaphore) -> None: ...
Comment thread
Akuli marked this conversation as resolved.
# Apparently this exists to *prohibit* use as a context manager.
def __enter__(self) -> object: ...
def __exit__(self, *args: Any) -> None: ...
# def __enter__(self) -> NoReturn: ... see: https://github.com/python/typing/issues/1043
# def __exit__(self, *args: Any) -> None: ...
def __iter__(self) -> Generator[Any, None, _ContextManager]: ...
def __await__(self) -> Generator[Any, None, _ContextManager]: ...
async def __aenter__(self) -> None: ...
Expand Down