builtins: Fix unconstrained overloads in set() and frozenset() #7944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
| def __class_getitem__(cls, __item: Any) -> GenericAlias: ... | ||
|
|
||
| class dict(MutableMapping[_KT, _VT], Generic[_KT, _VT]): | ||
| # __init__ should be kept roughly in line with `collections.UserDict.__init__`, which has similar semantics |
There was a problem hiding this comment.
Should we make a similar change to collections.UserDict.__init__
There was a problem hiding this comment.
Good point, made similar changes to constructors in that file.
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
May 25, 2022
AlexWaygood
reviewed
May 25, 2022
Thanks Alex! Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
May 25, 2022
Closed
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See microsoft/pyright#3501 (comment)
Related to #7928