Type PyInstaller.building.api and related modules#9730
Merged
JelleZijlstra merged 9 commits intopython:mainfrom Apr 27, 2023
Merged
Type PyInstaller.building.api and related modules#9730JelleZijlstra merged 9 commits intopython:mainfrom
PyInstaller.building.api and related modules#9730JelleZijlstra merged 9 commits intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Mar 9, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Looks like I started a review of this ages ago but never finished it — here's the partial review, with a few additional points to what Jelle said :)
Collaborator
Author
|
(I've been quite occupied last week, and I got sick this week, will go through reviews soon once I feel a bit better) |
Member
Take your time! |
This comment has been minimized.
This comment has been minimized.
Avasam
requested review from
AlexWaygood and
JelleZijlstra
and removed request for
AlexWaygood and
JelleZijlstra
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During #9721 I noticed that
PyInstaller.building.apiis probably part of the public API.And indeed this was missed in my initial
PyInstallerPR.Typed
PyInstaller.building.apiand related modules found in https://pyinstaller.org/en/stable/spec-files.htmlAdded comments to link to PyInstaller's documentation
Relaxed some
stubtest_allowlist.txtentries so it could test a bit more of what is typed and/or public.