Skip to content

Use a generic NamedTuple for concurrent.futures.DoneAndNotDoneFutures #9772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 2 commits into from
Feb 20, 2023
Merged

Use a generic NamedTuple for concurrent.futures.DoneAndNotDoneFutures #9772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6cd19a
Use a generic `NamedTuple` for `concurrent.futures.DoneAndNotDoneFutu…
AlexWaygood Feb 20, 2023
73a6e70
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions stdlib/concurrent/futures/_base.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import sys
import threading
from _typeshed import Unused
from collections.abc import Callable, Iterable, Iterator, Sequence
from collections.abc import Callable, Iterable, Iterator
from logging import Logger
from types import TracebackType
from typing import Any, Generic, TypeVar, overload
from typing_extensions import Literal, ParamSpec, Self, SupportsIndex
from typing import Any, Generic, NamedTuple, TypeVar
from typing_extensions import Literal, ParamSpec, Self

if sys.version_info >= (3, 9):
from types import GenericAlias
Expand Down Expand Up @@ -69,20 +69,9 @@ class Executor:

def as_completed(fs: Iterable[Future[_T]], timeout: float | None = None) -> Iterator[Future[_T]]: ...

# Ideally this would be a namedtuple, but mypy doesn't support generic tuple types. See #1976
class DoneAndNotDoneFutures(Sequence[set[Future[_T]]]):
if sys.version_info >= (3, 10):
__match_args__ = ("done", "not_done")
@property
def done(self) -> set[Future[_T]]: ...
@property
def not_done(self) -> set[Future[_T]]: ...
def __new__(_cls, done: set[Future[_T]], not_done: set[Future[_T]]) -> DoneAndNotDoneFutures[_T]: ...
def __len__(self) -> int: ...
@overload
def __getitem__(self, __i: SupportsIndex) -> set[Future[_T]]: ...
@overload
def __getitem__(self, __s: slice) -> DoneAndNotDoneFutures[_T]: ...
class DoneAndNotDoneFutures(NamedTuple, Generic[_T]):
done: set[Future[_T]]
not_done: set[Future[_T]]

def wait(
fs: Iterable[Future[_T]], timeout: float | None = None, return_when: str = "ALL_COMPLETED"
Expand Down