bisect: don't require Sequences#9813
Merged
JelleZijlstra merged 1 commit intopython:mainfrom Feb 25, 2023
Merged
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Member
|
It's a bit more complicated because it uses the C sequence protocol and therefore doesn't allow e.g. dicts, but I don't think we need to try to express that in the stub. |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the type of the first argument of
bisect_leftandbisect_right(and by designbisectas well) from thebisectmodule.Indeed, a full
Sequenceis not needed, only the following is needed:hiparameter isNone, only__getitem__and__len____getitem__I'm asking for
SupportsLenAndGetIteminstead of onlySupportsGetItemin the second case to avoid an exponential number of@overload.You can check that only these attributes are needed with the following code: