support conditional fields on TypedDict and NamedTuple#2263
Open
carljm wants to merge 2 commits intopython:mainfrom
Open
support conditional fields on TypedDict and NamedTuple#2263carljm wants to merge 2 commits intopython:mainfrom
carljm wants to merge 2 commits intopython:mainfrom
Conversation
carljm
added
topic: typing spec
5 tasks
JelleZijlstra
approved these changes
Apr 17, 2026
davidhalter
approved these changes
Apr 18, 2026
Collaborator
davidhalter
left a comment
davidhalter
left a comment
There was a problem hiding this comment.
Is it intentional that this is not specified for Protocol/Enums/Dataclasses? I would probably prefer this as a consistent change for all of these.
However I'm also good with this PR as a first step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We reached consensus on this a while back in this Discuss thread, but I never got around to actually making the PR.
Seems like in the meantime we accidentally implemented the strict version of the check for TypedDict in ty, but astral-sh/ruff#24702 fixes that. Happy to wait a bit to land this if other type checkers want to have conforming implementations ready, too.