Don't import anything from typing.py in our tests#387
Merged
AlexWaygood merged 1 commit intopython:mainfrom May 13, 2024
Merged
Don't import anything from typing.py in our tests#387AlexWaygood merged 1 commit intopython:mainfrom
typing.py in our tests#387AlexWaygood merged 1 commit intopython:mainfrom
Conversation
JelleZijlstra
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a theoretical footgun here where we could accidentally be testing the
typing.pyimplementation instead of our own implementation/re-export. It doesn't look like there's actually any issues here, but in any event, I think it's good for us to be explicit about when we actually want to use thetyping.pyversion of a symbol by refering to it astyping.$symbolrather than justsymbol