Skip to content

Conversation

@JelleZijlstra
Copy link
Member

No description provided.

This fixes wrapping of `Annotated` in an unwanted `Optional` in such cases.
Patch by [Daraan](https://github.com/Daraan).
- Fix error in subscription of `Unpack` aliases causing nested Unpacks
- Fix error in subscription of `Unpack` aliases causing nested Unpacks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitty nit:

Suggested change
- Fix error in subscription of `Unpack` aliases causing nested Unpacks
- Fix error in subscription of `Unpack` aliases causing nested Unpacks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't see this before hitting merge. I can do a fixup PR after I cut the release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is correct as written, the sentence continues on the next line

@JelleZijlstra JelleZijlstra merged commit 3c66d26 into python:main Mar 18, 2025
23 checks passed
@JelleZijlstra JelleZijlstra deleted the 4130rc1 branch March 18, 2025 18:02
@AlexWaygood
Copy link
Member

@Daraan thanks for all your contributions lately! That's quite an impressive list of changes authored by you here 😃 https://github.com/python/typing_extensions/blob/4.13.0rc1/CHANGELOG.md#release-4130rc1-march-18-2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants