-
-
Notifications
You must be signed in to change notification settings - Fork 126
Coverage: add detailed report to job summary #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+8
−0
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fa6ac8a
Coverage: add detailed report to job summary
brianschubert 37bbc65
shellcheck lints
brianschubert 3ae20e0
Move markdown report to before --fail-under=0
brianschubert 15f1325
Fix --fail-under
brianschubert 8f99e5f
Update .github/workflows/ci.yml
brianschubert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -180,6 +180,8 @@ jobs: | |
| echo "Creating coverage report..." | ||
| # Create xml file for further processing; Create even if below minimum | ||
| coverage xml --fail-under=0 | ||
| # Write markdown report to job summary | ||
| coverage report --fail-under=0 --format=markdown -m >> "$GITHUB_STEP_SUMMARY" | ||
|
|
||
| # For future use in case we want to add a PR comment for 3rd party PRs which requires | ||
| # a workflow with elevated PR write permissions. Move below steps into a separate job. | ||
|
|
@@ -210,6 +212,12 @@ jobs: | |
| # Note: it appears fail below min is one off, use fail_under -1 here | ||
| thresholds: '95 98' | ||
|
|
||
| - name: Add link to report badge | ||
| if: ${{ always() && steps.cov_xml_upload.outputs.artifact-id != '' }} | ||
| run: | | ||
| run_url="${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}?pr=${{ github.event.pull_request.number }}" | ||
| sed -i "1s|^\(!.*\)$|[\1]($run_url)|" code-coverage-results.md | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is clever! ...maybe a bit too clever 😆 the |
||
|
|
||
| - name: Add Coverage PR Comment | ||
| uses: marocchino/sticky-pull-request-comment@52423e01640425a022ef5fd42c6fb5f633a02728 # v2.9.3 | ||
| # Create PR comment when the branch is on the repo, otherwise we lack PR write permissions | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.