Add the ability to specific SSL cert and key files for library#30
Merged
ThomasTJdev merged 4 commits intopython36:masterfrom Jul 10, 2020
keslerm:tls-auth
Merged
Add the ability to specific SSL cert and key files for library#30ThomasTJdev merged 4 commits intopython36:masterfrom keslerm:tls-auth
ThomasTJdev merged 4 commits intopython36:masterfrom
keslerm:tls-auth
Conversation
ThomasTJdev
reviewed
Jun 27, 2020
ThomasTJdev
reviewed
Jun 27, 2020
| host: string | ||
| port: Port | ||
| sslOn: bool | ||
| sslCertFile: string |
Collaborator
There was a problem hiding this comment.
The brokers definition is sslCert and sslKey. Can we align the type naming? I prefer your proposal with the File appended.
https://github.com/zevv/nmqtt/blob/de90ffe0d830e7fbd99f1f36b319a43eea697a29/nmqtt.nim#L135-L140
Contributor
Author
There was a problem hiding this comment.
I had removed the File suffix but i think maybe you meant to update the MqttBroker definition and add the File suffix there?
ThomasTJdev
reviewed
Jun 27, 2020
ThomasTJdev
reviewed
Jun 27, 2020
Collaborator
|
Thanks @keslerm - nice PR. I only have a few comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to be able to preform Mutual TLS auth with a broker and the library didn't provide a way to set a ssl cert/key during connection so I added it in.
I didn't update the CLI clients since I'm not using them but I can add it in if you would like me to.