Disable shapely for are_polygons_intersecting and is_point_in_polygon
#1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Geometry module was moved, so might as well redo this one. It's a small thing anyway |
cspotcode
force-pushed
the
disable-shapely
branch
from
ee0a8f2 to
c80879c
Compare
Collaborator
Author
|
Rebased onto the latest |
Member
|
Might want to check if we're mentioning shapely anywhere in docs or other places in the codebase. We don't want to cause confusion. |
Collaborator
Author
|
Good call, searching the codebase shows it's not mentioned in docs, only in the changelog for 3.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We benchmarked shapely in #1535 and found that it's way slower when used in these two functions. We discussed on Discord that we can disable shapely now, and leave the code in-place for someone to investigate in the future.
This does not disable using shapely in other parts of arcade, such as pathfinding. Shapely may still be faster in those other areas, so we should not disable it.