Skip to content

Conversation

@Aurelioghs
Copy link
Contributor

@einarf einarf mentioned this pull request Mar 1, 2023
@einarf
Copy link
Member

einarf commented Mar 1, 2023

Echoing what Paul said in the other PR:

Hi! Let us know if you need any assistance in putting together a PR for this project.

As it looks like you are still working on this, you might want to covert it to a 'draft' PR. Then when you are ready for it to be reviewed, mark it as ready to review.

Again, feel free to ask questions. The Arcade discord is a good spot for getting quick info.

@Aurelioghs Aurelioghs marked this pull request as draft March 1, 2023 21:46
@Aurelioghs Aurelioghs marked this pull request as ready for review March 1, 2023 22:16
@Aurelioghs Aurelioghs marked this pull request as draft March 1, 2023 23:53
@Aurelioghs Aurelioghs marked this pull request as ready for review March 1, 2023 23:56
@Aurelioghs Aurelioghs closed this Mar 2, 2023
@Aurelioghs Aurelioghs reopened this Mar 2, 2023
Copy link
Member

@Cleptomania Cleptomania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'd like to see the word joystick replaced with controller. Pyglet offers two controller APIs, one being controller and the other being joystick. This documentation is for the controller API, so it would be best if this document only referred to it as such to avoid confusion.

@Aurelioghs Aurelioghs marked this pull request as draft March 4, 2023 02:40
@Aurelioghs Aurelioghs marked this pull request as ready for review March 4, 2023 18:20
Copy link
Member

@Cleptomania Cleptomania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one issue with the Sphinx build, other than that looks good, if you can update that I'd say this is good to merge.

@Cleptomania
Copy link
Member

There is a lingering issue with the sphinx build, but it's only slightly related to this PR, I will just go ahead and merge this and fix it.

@Cleptomania Cleptomania merged commit 7aeb758 into pythonarcade:development Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants