-
Notifications
You must be signed in to change notification settings - Fork 358
How to use controller documentation/tutorials issue(#1475) #1590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to use controller documentation/tutorials issue(#1475) #1590
Conversation
updates to Different types of controllers
update to Different types of controllers
|
Echoing what Paul said in the other PR:
|
Cleptomania
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I'd like to see the word joystick replaced with controller. Pyglet offers two controller APIs, one being controller and the other being joystick. This documentation is for the controller API, so it would be best if this document only referred to it as such to avoid confusion.
Cleptomania
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this one issue with the Sphinx build, other than that looks good, if you can update that I'd say this is good to merge.
|
There is a lingering issue with the sphinx build, but it's only slightly related to this PR, I will just go ahead and merge this and fix it. |
Co-author: @JDLiang100, @michellejtan, @Aurelioghs