-
Notifications
You must be signed in to change notification settings - Fork 358
Deprecate lrtb (left, right, top, bottom)
#1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Made the warning message more clear.
+ Made the warning decorator accept the new_name instead of warning message + Add deprecated warning in docstring
pushfoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. I'll spare you formatting minute and request 3 changes which seem to be actually important.
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
pushfoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for leaving a separate review, but I think the new functions should raise ValueError instead of AttributeError since there's no attribute access involved.
+ Renamed `NameChangeWarning` to `ReplacementWarning` + Used ValueError instead of AttributeError
pushfoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the requested changes! It looks good! 👍
Please mark the earlier comment threads as resolved & we should be ready to merge.
Relevant discussion: https://discord.com/channels/458662222697070613/1087007892575617086/1087015976157073428
Mentions for the world
lrtbin the whole arcade package after deprecation: