Skip to content

Improve Color's inheritance safety & type annotation accuracy #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 20, 2023
Merged

Improve Color's inheritance safety & type annotation accuracy #1699

merged 11 commits into from
Apr 20, 2023

Conversation

@pushfoo
Copy link
Member

@pushfoo pushfoo commented Apr 13, 2023 •
edited
Loading

  1. Improve inheritance safety by using cls or self.__class__ where appropriate instead of Color
  2. Add inheritance safety to Color's unit tests
  3. Use the Self annotation for accuracy since we have access to a backport of it on 3.8+ via typing_extensions

pushfoo added 11 commits April 13, 2023 14:25
@pushfoo
Make Color type's deepcopy method precise about types when subclassing
9a493ed
@pushfoo
Make the Color subclass module-wide + its instance a fixture
49815ed
@pushfoo
Make Color.from_iterable inheritance-safe
c60207d
@pushfoo
Make Color.from_gray inheritance-safe
e4d59ec
@pushfoo
Use Self annotation for Color.from_uint24 + add inheritance safety test
32a6e7e
@pushfoo
Use Self type annotation on Color.from_uint32 + add inheritance safet…
ea8b09b 
…y test
@pushfoo
Use Self type annotation on Color.from_normalized + add inheritance s…
bdbdd00 
…afety test
@pushfoo
Use Self annotation on Color.from_hex_string + add inheritance safety…
1e912ba 
… test
@pushfoo
Use Self annotation on Color.random + add inheritance safety test
d09b278
@pushfoo
Remove fixture used only once to be consistent with arcade's fixture-…
e992346 
…avoidant style
@pushfoo
Increase specificity & fix grammar in Color's deepcopy docstring
a1a1e25
@einarf einarf merged commit 51adf79 into pythonarcade:development Apr 20, 2023
@pushfoo pushfoo deleted the color_inheritance_safety branch May 7, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvcraven pvcraven pvcraven approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pushfoo @pvcraven @einarf