Skip to content

#1695 fixed : Tiles that were rotated in Tiled have wrong hitbox #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2023
Merged

#1695 fixed : Tiles that were rotated in Tiled have wrong hitbox #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
619dae1
#1695 fixed : Tiles that were rotated in Tiled have wrong hitbox
shivaniarbat Apr 22, 2023
6d558eb
#1695 fixed broken unit tests : Tiles that were rotated in Tiled have…
shivaniarbat Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions arcade/texture/transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def transform_hit_box_points(
points: PointList,
) -> PointList:
points = FlipLeftRightTransform.transform_hit_box_points(points)
points = Rotate270Transform.transform_hit_box_points(points)
points = Rotate90Transform.transform_hit_box_points(points)
return points


Expand All @@ -209,7 +209,7 @@ def transform_hit_box_points(
points: PointList,
) -> PointList:
points = FlipLeftRightTransform.transform_hit_box_points(points)
points = Rotate90Transform.transform_hit_box_points(points)
points = Rotate270Transform.transform_hit_box_points(points)
return points


Expand Down
4 changes: 2 additions & 2 deletions tests/unit/texture/test_texture_transform_values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_flip_top_bottom_transform():
def test_transpose_transform():
# Transpose
result = TransposeTransform.transform_hit_box_points(HIT_BOX_POINTS)
assert result == ((-64.0, -64.0), (-64.0, 64.0), (64.0, 64.0), (64.0, -64.0))
assert result == ((64.0, 64.0), (64.0, -64.0), (-64.0, -64.0), (-64.0, 64.0))
# Flip back
result = TransposeTransform.transform_hit_box_points(result)
assert result == HIT_BOX_POINTS
Expand All @@ -106,7 +106,7 @@ def test_transpose_transform():
def test_transverse_transform():
# Transverse
result = TransverseTransform.transform_hit_box_points(HIT_BOX_POINTS)
assert result == ((64.0, 64.0), (64.0, -64.0), (-64.0, -64.0), (-64.0, 64.0))
assert result == ((-64.0, -64.0), (-64.0, 64.0), (64.0, 64.0), (64.0, -64.0))
# Flip back
result = TransverseTransform.transform_hit_box_points(result)
assert result == HIT_BOX_POINTS
Expand Down