Skip to content

Fix 3D sphere example always saying wireframe is False #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Fix 3D sphere example always saying wireframe is False #1732

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdb1edf
Fix broken wireframe toggle display
pushfoo Apr 27, 2023
6e13961
Stop updating irrelevant labels during keypresses
pushfoo Apr 27, 2023
5ed2957
Fix initial capitalization on cull face label
pushfoo Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions arcade/examples/gl/3d_sphere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def __init__(self, width, height, title):

self.text_batch = Batch()
self.text_cull = arcade.Text(
"F2: Toggle cull face (true)",
"F2: Toggle cull face (True)",
start_x=10, start_y=10, font_size=15, color=arcade.color.WHITE,
batch=self.text_batch
)
Expand Down Expand Up @@ -138,26 +138,29 @@ def on_update(self, dt):
def on_key_press(self, key, modifiers):
if key == arcade.key.ESCAPE:
self.close()

elif key == arcade.key.F:
self.set_fullscreen(not self.fullscreen)
self.text_fs.text = f"F: Toggle fullscreen ({self.fullscreen})"

elif key == arcade.key.SPACE:
self.wireframe = not self.wireframe
self.set_vsync(True)
self.text_wireframe.text = f"SPACE: Toggle wireframe ({self.wireframe})"

elif key == arcade.key.F1:
if self.ctx.DEPTH_TEST in self.flags:
self.flags.remove(self.ctx.DEPTH_TEST)
else:
self.flags.add(self.ctx.DEPTH_TEST)
self.text_depth.text = f"F1: Toggle depth test ({self.ctx.DEPTH_TEST in self.flags})"

elif key == arcade.key.F2:
if self.ctx.CULL_FACE in self.flags:
self.flags.remove(self.ctx.CULL_FACE)
else:
self.flags.add(self.ctx.CULL_FACE)

self.text_wireframe.text = f"SPACE: Toggle wireframe ({self.ctx.wireframe})"
self.text_fs.text = f"F: Toggle fullscreen ({self.fullscreen})"
self.text_depth.text = f"F1: Toggle depth test ({self.ctx.DEPTH_TEST in self.flags})"
self.text_cull.text = f"F2: Toggle cull face ({self.ctx.CULL_FACE in self.flags})"
self.text_cull.text = f"F2: Toggle cull face ({self.ctx.CULL_FACE in self.flags})"

def on_mouse_drag(self, x, y, dx, dy, buttons, modifiers):
self.drag = True
Expand Down