#1779 Include VideoPlayerView in exports #1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushfoo
approved these changes
May 17, 2023
Member
pushfoo
left a comment
pushfoo
left a comment
There was a problem hiding this comment.
I think this looks good as-is. 👍
I didn't even know we had this feature, and I appreciate you bringing it to my attention!
If you have time for a follow-up PR, I'd appreciate it if you could take a look at the following:
- Add a small public domain MP4 we can include instead of the hard link to a local file on the original author's device
- Type annotations
- Better docstrings & formatting
gran4
suggested changes
May 17, 2023
Contributor
|
@pvcraven it has a mistake. should be made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add the video player view for users. Especially helpful in quick prototyping and reducing boilerplate.