created a depth of field example #2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I've made a PR (https://github.com/DragonMoffon/arcade/pull/3) to clean this up a bit. It won't be perfect yet, but this should make it legible faster than going through the code review process. Once it's merged, I think it should be good. |
* Add top-level docstring with run instructions * Clean up source style for shaders using dedent * Make sprite instantiation more legible * Make clear color cleaner and less hardcoded * Make render program a property * Switch to batch label instead of draw_text * Add annotations and comments for clarity * Clean up imports and spacing * Remove redundant Color creation since we convert internally anyway * Add docstring for DepthOfField * Expand top-level docstring * Spacing + initial label value fix * Make the focus change speed a keyword argument of window + explain it in docstrings * Fix mypy issue
pushfoo
approved these changes
Mar 18, 2024
Member
pushfoo
left a comment
pushfoo
left a comment
There was a problem hiding this comment.
LGTM. It's experimental and readable enough for us to finish polishing it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a super quick example for someone on Discord. I thought it might be nice to have as an example in base arcade. It relies on the experimental post-processing blur class.