Fix GH Actions, make Python3.12 the oldest supported version #6
+104
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CI/CD workflows and build configuration for the pylibbpf project. Despite the title "Print pylibbpf dir in test", the changes primarily focus on improving build reliability and test coverage across different Python versions.
Key changes:
- Updated CI workflows to use recursive submodule checkout and enhanced verification steps
- Modified Python version support from 3.11 to 3.12-3.13 in wheel building
- Added setuptools package configuration in pyproject.toml
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| setup.py | Removed zip_safe=False parameter from setup call |
| pyproject.toml | Added setuptools package discovery and package-data configuration |
| .github/workflows/wheels.yml | Updated submodule checkout, Python versions (3.12-3.13), enhanced test command with BpfObject assertion, and added build dependencies |
| .github/workflows/pip.yml | Restructured workflow with detailed diagnostic steps, recursive submodule checkout, updated dependencies, and comprehensive build verification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
r41k0u
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.