feat: Citas aleatorias en página de inicio#432
Merged
sdelquin merged 6 commits intopythoncanarias:mainfrom Nov 4, 2021
Merged
Conversation
Contributor
Author
|
@sdelquin Hago el draft PR para tu revisión, el valor por omisión del intervalo es de 60 segundos y se puede configurar en los Settings de la aplicación, el javascript lo coloque en la página índex.html que es la que contiene el mayor porcentaje de los cambios. |
Contributor
Author
|
Ya ví algo que puedo corregir, es el nombre de la variable que recibe el llamado al API. |
sdelquin
added
hacktoberfest-accepted
Contributor
|
Hola @navascogt. He refactorizado un poco el código pero sin tu empuje seguro que hubiera tardado mucho en hacerse. Gracias! 🚀 |
Contributor
Author
|
Muchas gracias por la oportunidad @sdelquin, veo que ya esta en el sitio y funcionando!!! Estoy revisando cómo lo refactoraste y seguir aprendiendo!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.