Conversation
This gives a description of time since the program started, for the /status command.
First one is used in the /start command, second one defines default log level for the modules using logging (default is WARNING)
jdevera
approved these changes
May 16, 2019
| bot.send_message(chat_id=update.message.chat_id, text=config.BOT_GREETING) | ||
|
|
||
|
|
||
| def help(bot, update): |
Contributor
There was a problem hiding this comment.
Como help es un builtin, aunque obviamente no lo vamos a usar aquí, quizá estaría bien hacer un poor-man-namespacing de las funciones de comando poniendoles numbres como command_help, command_start y así.
Contributor
Author
There was a problem hiding this comment.
Tienes razon, buena idea, lo hago ya mismo
Contributor
Author
There was a problem hiding this comment.
Lo hago en otra rama porque esta ya esta integrada en Master
| ) | ||
| logger.info('Starting bot...') | ||
| logger.info(f'- Log level is {config.LOG_LEVEL}') | ||
| logger.info(f'- Poll interval is {config.POLL_INTERVAL}') |
Contributor
There was a problem hiding this comment.
Genial idea, lo de poner la config en el log. De hecho, podríamos porner más. PrettyConf no tendrá alguna manera de acceder a todos los valores de configuración, ¿verdad?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.