Skip to content

Conversation

@wyuenho
Copy link
Contributor

@wyuenho wyuenho commented Jun 13, 2017

define-minor-mode by default connects to a group without the trailing -mode, so if you define yet another group called pyenv-mode, you will have created 2 customize groups for the same package. This fixes the issue.

`define-minor-mode` by default connects to a group [without the trailing `-mode`](http://www.gnu.org/software/emacs/manual/html_node/elisp/Defining-Minor-Modes.html), so if you define yet another group called `pyenv-mode`, you will have created 2 customize groups for the same package. This fixes the issue.
@proofit404
Copy link
Contributor

Is it possible to pass old pyenv-mode group to the minor-mode?

@wyuenho
Copy link
Contributor Author

wyuenho commented Jun 15, 2017 via email

@wyuenho
Copy link
Contributor Author

wyuenho commented Aug 1, 2017

@proofit404 Can this be merged? This works well.

@proofit404 proofit404 merged commit 215b7f0 into pythonic-emacs:master Aug 1, 2017
@wyuenho
Copy link
Contributor Author

wyuenho commented Aug 1, 2017

Thanks!

@proofit404
Copy link
Contributor

Sorry completely forgot about it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants