Fix getting remote port #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tramp-file-name-host returns hostname without the hash-port part
Closed
proofit404
suggested changes
Aug 7, 2018
| (when (s-contains-p "#" hostname) | ||
| (string-to-number (replace-regexp-in-string "\\`.*#" "" hostname))))) | ||
| (let ((port (tramp-file-name-port (tramp-dissect-file-name (pythonic-aliased-path default-directory))))) | ||
| (if (stringp port) |
Contributor
Author
There was a problem hiding this comment.
emacs 25 returns tramp-file-name-port as a number, and emacs 26 returns it as a string. This little piece makes them compatible. I probably should add a comment in the code, because it looks indeed not clear
Contributor
|
Sorry, it was pending for too long! |
Contributor
Author
|
Added a comment to explain |
proofit404
approved these changes
Aug 8, 2018
| (when (s-contains-p "#" hostname) | ||
| (string-to-number (replace-regexp-in-string "\\`.*#" "" hostname))))) | ||
| (let ((port (tramp-file-name-port (tramp-dissect-file-name (pythonic-aliased-path default-directory))))) | ||
| ;; In Emacs 25, `tramp-file-name-port' returns number, |
Contributor
|
Great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5