Skip to content

Conversation

@fanfilmu
Copy link

Proposed solution for #80

@mdavidn
Copy link

mdavidn commented Jun 11, 2019

To avoid a breaking change to the API, you could use Net::HTTP rather than the http gem.

Net::HTTP ships with Ruby. Any application that prefers a different client library (e.g. for VCR) should simply avoid the :remote option.

@fanfilmu
Copy link
Author

Hi and thank you for your comment @mdavidn !

Sure, it is an option. Depends on what @pythonicrubyist decides, but in my opinion, we should not avoid the breaking change here... For me, it seems really weird for Excel parser library to be able to download files from the internet.

I would suggest going with the Unix philosophy here, do one thing and do it well ;)

@mdavidn
Copy link

mdavidn commented Jun 14, 2019

I don't disagree. I just don't want a major version bump to be a reason to keep the http dependency.

@savfischer
Copy link

I really appreciate the ease of parsing excel files from a remote location this allows. If it is removed maybe it could be a plugin, like shrine does.

@mdavidn
Copy link

mdavidn commented Dec 7, 2019

Ruby already makes it very easy to read files from a remote location. This library does not need additional dependencies to support that feature.

require 'open-uri'
URI('https://path/to/excel/file.xlsx').read

@pythonicrubyist
Copy link
Owner

I completely agree that this library should not have had the remote option at the first place, but I do not want to introduce a breaking change to a library with over over a milliton downloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants