Remove http requirement and replace with OpenURI #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbernheisel
force-pushed
the
db-remove-http
branch
from
3ec86a6 to
e9eb33d
Compare
Closed
dbernheisel
force-pushed
the
db-remove-http
branch
from
e9eb33d to
2626cfe
Compare
Owner
|
Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #81 and Resolves #80
There were no tests for parsing remote files, so I added them but wasn't sure where to find a good online sample. I googled for some public files that fit two scenarios, and excluded these tests from running by default since they hit the internet.
This removes the
httpgem dependency and replaces it with Ruby's stdlibopen-uriAlso, running
rakefailed for me because it didn't haverequire 'time', so I added that.