Add: Instructions to preview changes on netlify#22
Merged
astronomersiva merged 1 commit intopythonindia:masterfrom Apr 4, 2019
Merged
Add: Instructions to preview changes on netlify#22astronomersiva merged 1 commit intopythonindia:masterfrom
astronomersiva merged 1 commit intopythonindia:masterfrom
Conversation
| We recommend creating a new branch for each feature task/bug since it makes easier to edit | ||
| commits in future if needed. | ||
|
|
||
| After submitting a pull request preview your changes by going through the checks section in |
| commits in future if needed. | ||
|
|
||
| After submitting a pull request preview your changes by going through the checks section in | ||
| last of the pull request page and click `Details` of the `netlify/cranky-borg-621833/deploy-preview` check. |
Member
There was a problem hiding this comment.
There is a separate Checks tab. We can talk about that instead of this approach.
Contributor
Author
There was a problem hiding this comment.
Yes wrt to the debugging and review going to the checks tab and previewing every page changed is best, also from index link anyone can also preview any other page also, so I am also in favour of going through the checks tab and previewing every tab
Should I change the screenshot and update the instructions?
Member
There was a problem hiding this comment.
Yes, we can update this text to tell people to click that tab and access the changed files.
| After submitting a pull request preview your changes by going through the checks section in | ||
| last of the pull request page and click `Details` of the `netlify/cranky-borg-621833/deploy-preview` check. | ||
|
|
||
|  |
Member
There was a problem hiding this comment.
Alt Names should be meaningful.
RaiVaibhav
force-pushed
the
netlify_preview
branch
from
461d9cf to
d04b83a
Compare
Member
|
Thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions to preview changes on a PR on netlify