Skip to content

Fix button link definition and style #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrick91 merged 1 commit into from
Mar 17, 2018
Merged

Fix button link definition and style #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/src/components/button/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, { AnchorHTMLAttributes } from 'react';
import { Box } from '../box';
import styled from '../../styled';
import { ButtonVariant } from './types';
Expand Down Expand Up @@ -27,6 +27,7 @@ const button = (
color ${props => props.theme.timings[0]}s ease-out;
cursor: pointer;
text-transform: uppercase;
text-decoration: none;
font-family: ${props => props.theme.fonts.button};
display: inline-block;
`;
Expand All @@ -52,7 +53,7 @@ const button = (
);
};

type ButtonLinkProps = Props & {};
type ButtonLinkProps = Props & AnchorHTMLAttributes<HTMLAnchorElement>;

export const Button = (props: Props) => button(props, 'button');
export const ButtonLink = (props: ButtonLinkProps) => button(props, 'a');